Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/magefile/mage to v1.9.0 #15999

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jan 31, 2020

What does this PR do?

This PR update github.com/magefile/mage to v1.9.0 to make moving to modules smoother.

Why is it important?

The minimal selected version for mage is currently v1.9.0. By updating it now, it makes the actual go-modules PR smaller.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made the corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Related issues

Needed by #15998

@kvch kvch added [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Jan 31, 2020
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kvch
Copy link
Contributor Author

kvch commented Jan 31, 2020

Failing tests are unrelated.

@kvch kvch merged commit 3c0fee8 into elastic:master Jan 31, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Jan 31, 2020
kvch added a commit to kvch/beats that referenced this pull request Feb 3, 2020
@kvch kvch added the v7.7.0 label Feb 3, 2020
kvch added a commit that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants