Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported versions to nats tests #16317

Merged
merged 4 commits into from Feb 18, 2020
Merged

Conversation

@jsoriano
Copy link
Member

jsoriano commented Feb 13, 2020

What does this PR do?

  • Add a common entry point to nats docker images so we can use the same docker compose and Dockerfile.
  • Add supported-versions.yml for nats service.
  • Add support for 2.1.4.

Why is it important?

  • It helps to reuse the docker compose file for future end to end testing.
  • NATS_VERSION can be used now to configure different versions without depending on the name of the service.
@jsoriano jsoriano requested review from mdelapenya and ChrsMark Feb 13, 2020
@jsoriano jsoriano requested a review from elastic/integrations as a code owner Feb 13, 2020
@jsoriano jsoriano self-assigned this Feb 13, 2020
@jsoriano jsoriano force-pushed the jsoriano:nats-docker-tests branch from b0d4fdd to ba3daf3 Feb 13, 2020
@jsoriano jsoriano force-pushed the jsoriano:nats-docker-tests branch from ba3daf3 to d9dc3fa Feb 13, 2020
Copy link
Contributor

ChrsMark left a comment

lgmt! not sure if this needs a changelog for due to the new supported version.

@jsoriano jsoriano merged commit 46cf3dd into elastic:master Feb 18, 2020
2 of 4 checks passed
2 of 4 checks passed
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
CLA All commits passed the check
Details
elasticsearch-ci/docs Build finished.
Details
@jsoriano jsoriano deleted the jsoriano:nats-docker-tests branch Feb 18, 2020
@zube zube bot removed the [zube]: In Review label Feb 18, 2020
@zube zube bot added the [zube]: Done label Feb 18, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Feb 18, 2020
Add a common entry point to nats docker images so we
can use the same docker compose and Dockerfile.
Add supported-versions.yml for nats service.
Add support for 2.1.4.

(cherry picked from commit 46cf3dd)
jsoriano added a commit to jsoriano/beats that referenced this pull request Feb 18, 2020
Add a common entry point to nats docker images so we
can use the same docker compose and Dockerfile.
Add supported-versions.yml for nats service.
Add support for 2.1.4.

(cherry picked from commit 46cf3dd)
jsoriano added a commit that referenced this pull request Feb 18, 2020
Add a common entry point to nats docker images so we
can use the same docker compose and Dockerfile.
Add supported-versions.yml for nats service.
Add support for 2.1.4.

(cherry picked from commit 46cf3dd)
@andresrc andresrc removed the [zube]: Done label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.