Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kubernetes provider to recognize namespace level defaults #16321

Open
wants to merge 1 commit into
base: master
from

Conversation

@vjsamuel
Copy link
Contributor

vjsamuel commented Feb 14, 2020

This PR allows namespace level defaults to be configured on the namespace object for either service or pod hints autodiscover. This will need:

add_resource_metadata.namespace.enabled: true

to be set on the kubernetes autodiscover provider.

This PR has a known gap where a pod is deployed before the namespace annotations are added. In this case, autodiscover wouldnt be able to add in the defaults. To fix that behavior we would need to ensure that we handle resync events as updates. Currently we ignore resync events as the resource version remains the same.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Feb 14, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Feb 14, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@vjsamuel vjsamuel changed the title Add support for kubernetes provider to recognize namespace level defa… Add support for kubernetes provider to recognize namespace level defaults Feb 14, 2020
@blakerouse

This comment has been minimized.

Copy link
Contributor

blakerouse commented Feb 18, 2020

We have a template that is generally used when creating a PR, could you update this PR to fill out all those sections.

Also did (or could) you file a bug for the behavior your trying to solve and can you provide steps on how to test this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.