Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor kube event resysncs to handle missed watch events #16322

Open
wants to merge 1 commit into
base: master
from

Conversation

@vjsamuel
Copy link
Contributor

vjsamuel commented Feb 14, 2020

This PR adds a HonorReSyncs watcher option to allow resyncs to be queued in as add events. The deduplication on the autodiscover module would ensure that we don't spin up more than one.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Feb 14, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Feb 14, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@vjsamuel vjsamuel requested a review from exekias Feb 14, 2020
@vjsamuel vjsamuel force-pushed the vjsamuel:handle_kube_resync branch from 5dd4cdd to 3217dac Feb 14, 2020
@exekias

This comment has been minimized.

Copy link
Member

exekias commented Feb 14, 2020

Thank you for opening!!. What was the behavior you were seeing before this change? ok to test

@vjsamuel vjsamuel force-pushed the vjsamuel:handle_kube_resync branch from 3217dac to ffb8669 Feb 15, 2020
@vjsamuel

This comment has been minimized.

Copy link
Contributor Author

vjsamuel commented Feb 15, 2020

@exekias the behavior before is that resyncs are swallowed up as the resource version isnt changed. ideally we should digest them gracefully. i have amended the PR to change the autodiscover worker to be able to look at an add event and say, "if a config is already running, keep it running. if new configs are coming in, replace all the old ones with new ones." this should allow the namespace default PR to allow changes on annotations to be able to update the config during a relist.

@vjsamuel vjsamuel force-pushed the vjsamuel:handle_kube_resync branch from ffb8669 to 9156bbc Feb 15, 2020
@vjsamuel vjsamuel force-pushed the vjsamuel:handle_kube_resync branch from 9156bbc to c5c08c7 Feb 15, 2020
@blakerouse

This comment has been minimized.

Copy link
Contributor

blakerouse commented Feb 18, 2020

We have a template that is generally used when creating a PR, could you update this PR to fill out all those sections.

Also did (or could) you file a bug for the behavior your trying to solve and can you provide steps on how to test this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.