New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prospector meta data on prospector level to event #2290

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
2 participants
@ruflin
Collaborator

ruflin commented Aug 17, 2016

This simplifies the creation of events on the harvester level and automatically provides the functionality for future types of harvesters

@urso

This comment has been minimized.

Show comment
Hide comment
@urso

urso Aug 17, 2016

Collaborator

This change seems to change the event to be only partially by harvester.

I see why it makes sense to fill these common setting in prospector, but if possible i'd avoid having to pass partially initialized values.

Collaborator

urso commented Aug 17, 2016

This change seems to change the event to be only partially by harvester.

I see why it makes sense to fill these common setting in prospector, but if possible i'd avoid having to pass partially initialized values.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Aug 17, 2016

Collaborator

I think the way it will look in the long run is that there is generic event object which is valid across all prospectors, and each prospector with its harvester will have potential additional fields on top. Somehow reminds me of: #2239 I think the above event is completely valid also without the additional fields from the prospector. As it simplifies the harvester this is a step forward.

Collaborator

ruflin commented Aug 17, 2016

I think the way it will look in the long run is that there is generic event object which is valid across all prospectors, and each prospector with its harvester will have potential additional fields on top. Somehow reminds me of: #2239 I think the above event is completely valid also without the additional fields from the prospector. As it simplifies the harvester this is a step forward.

@ruflin ruflin added in progress and removed review labels Sep 20, 2016

@ruflin ruflin added the review label Jan 20, 2017

@ruflin ruflin removed the in progress label Jan 31, 2017

Add prospector meta data on prospector level to event
This simplifies the creation of events on the harvester level and automatically provides the functionality for future types of harvesters.

General idea
* Harvester should have as few knowledge as possible
* Prospector will do the generic creation of the event

mergeJSONFields is something that should happen on a prospector level and not be part of the input.Event in the end.
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Feb 8, 2017

Collaborator

jenkins, retest it

Collaborator

ruflin commented Feb 8, 2017

jenkins, retest it

@urso urso merged commit 62113b1 into elastic:master Feb 8, 2017

4 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment