New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP address to -devices command output #2327

Merged
merged 4 commits into from Aug 26, 2016

Conversation

Projects
None yet
3 participants
@noricube
Contributor

noricube commented Aug 20, 2016

On Windows, device description is a device driver name.
It is confusing when there are multiple same devices.

image

So, I added a IP address to -devices command output.
It is helpful to set up a sniffer interface.

image

@elasticsearch-release

This comment has been minimized.

Show comment
Hide comment
@elasticsearch-release

elasticsearch-release Aug 20, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

elasticsearch-release commented Aug 20, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@elasticsearch-release

This comment has been minimized.

Show comment
Hide comment
@elasticsearch-release

elasticsearch-release Aug 20, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

elasticsearch-release commented Aug 20, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Aug 22, 2016

Collaborator

Thanks for the addition. Please run make fmt to make sure your code adheres to the Golang coding guidelines.

It would be nice if there would be a system test for these changes to confirm it works as expected. But as there is not test yet that you can just extend it is probably a little bit more complicated.

Could you also update the CHANGELOG.asciidoc file with this change?

Collaborator

ruflin commented Aug 22, 2016

Thanks for the addition. Please run make fmt to make sure your code adheres to the Golang coding guidelines.

It would be nice if there would be a system test for these changes to confirm it works as expected. But as there is not test yet that you can just extend it is probably a little bit more complicated.

Could you also update the CHANGELOG.asciidoc file with this change?

@noricube

This comment has been minimized.

Show comment
Hide comment
@noricube

noricube Aug 23, 2016

Contributor

Hello.

I had to apply the golang coding guidelines.
And added changes to CHANGELOG.asciidoc.

Thanks.

Contributor

noricube commented Aug 23, 2016

Hello.

I had to apply the golang coding guidelines.
And added changes to CHANGELOG.asciidoc.

Thanks.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Aug 25, 2016

Collaborator

jenkins, test it

Collaborator

ruflin commented Aug 25, 2016

jenkins, test it

@ruflin ruflin merged commit 6f86e53 into elastic:master Aug 26, 2016

4 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Aug 26, 2016

Collaborator

@noricube Thanks a lot for the contribution.

Collaborator

ruflin commented Aug 26, 2016

@noricube Thanks a lot for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment