New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map concurrent bug #2509

Merged
merged 2 commits into from Sep 13, 2016

Conversation

Projects
None yet
3 participants
@amyangfei

amyangfei commented Sep 9, 2016

crawler.Registrar.state may be accessed both in function (*Prospector).scan and pulling the events from the crawler.Registrar.Persist, which leads to fatal error: concurrent map read and map write

@elasticsearch-release

This comment has been minimized.

elasticsearch-release commented Sep 9, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticsearch-release

This comment has been minimized.

elasticsearch-release commented Sep 9, 2016

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@ruflin ruflin referenced this pull request Sep 12, 2016

Closed

crash after 1.3.0 upgrade #2526

@ruflin

This comment has been minimized.

Collaborator

ruflin commented Sep 12, 2016

@amyangfei Thanks a lot for spotting this and providing a fix. I will look into this ASAP.

@ruflin

This comment has been minimized.

Collaborator

ruflin commented Sep 12, 2016

@amyangfei I had a closer look at this and I assume this error happens directly on startup especially with config files with a large number of prospectors defined?

Can you update the CHANGELOG.asciidoc und bug fixes?

@amyangfei

This comment has been minimized.

amyangfei commented Sep 13, 2016

@ruflin I have updated the CHANGELOG.asciidoc 😄

@ruflin ruflin merged commit 8d9477e into elastic:1.3 Sep 13, 2016

3 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Collaborator

ruflin commented Sep 13, 2016

@amyangfei Merged. Thanks a lot for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment