Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic if logging directory cannot be generated #2571

Merged
merged 1 commit into from Sep 19, 2016

Conversation

@ruflin
Copy link
Collaborator

commented Sep 16, 2016

  • Assigns log rotator only after successful creation. Otherwise panic can happen during shutdown if directory cannot be generated as it tries to log.

Closes #2490

* Assigns log rotator only after successful creation. Otherwise panic can happen during shutdown if directory cannot be generated as it tries to log.

Closes #2490
@tsg tsg merged commit 6ae821b into elastic:master Sep 19, 2016
4 checks passed
4 checks passed
CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details
tsg added a commit to tsg/beats that referenced this pull request Sep 19, 2016
* Assigns log rotator only after successful creation. Otherwise panic can happen during shutdown if directory cannot be generated as it tries to log.

Closes elastic#2490
monicasarbu added a commit that referenced this pull request Sep 19, 2016
Backport: Fix panic if logging directory cannot be generated (#2571)
suraj-soni added a commit to suraj-soni/beats that referenced this pull request Sep 20, 2016
* Assigns log rotator only after successful creation. Otherwise panic can happen during shutdown if directory cannot be generated as it tries to log.

Closes elastic#2490
@tsg tsg removed the needs_backport label Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.