New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cloudwatch metricset collecting duplicate data points #27248
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
* Fix cloudwatch metricset collecting duplicate data points * add changelog (cherry picked from commit b8cbdee)
* Fix cloudwatch metricset collecting duplicate data points * add changelog (cherry picked from commit b8cbdee)
While I'm +1 to with this change I think it won't fix all cases we are seeing? We double the query period to ensure we always get same data, but we are seeing this can result on intermittent data duplication when the latency is big enough. I wonder if we should invest in better handling of these latency situations and reduce the range we request to the period. Thoughts @kaiyan-sheng? Some things we could do:
|
Yep thanks @exekias this is just a temporary fix for the bug as a workaround. I'm working on a permanent fix for this issue.
|
Does it make sense to look for dates in the future? Any concern with known delays on the cloudwatch side? |
What does this PR do?
When a CloudWatch data point lands on the start time or end time, it gets collected twice. This PR is to fix this bug by moving the start time by one second so the end time of the first collection period does not overlap with the start time of the second collection period.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues