Fix issue when clean_removed and clean_inactive were used together #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at states were not directly removed from the registry The clean_inactive option was updating the TTL after clean_removed was applied. This lead to the issue that during every run clean_removed updated the state and clean_inactive reset the TTL. In the end removed files were never purged from the registry if both options were used together. * Test added to verify fix * Updated incorrect log message Closes elastic#2646
ruflin
added
bug
review
Filebeat
andrewkroh
reviewed
Oct 11, 2016
| // Add ttl if cleanOlder is enabled | ||
| if p.config.CleanInactive > 0 { | ||
| // Add ttl if cleanOlder is enabled and TTL is not already 0 | ||
| if p.config.CleanInactive > 0 && event.State.TTL != 0 { |
There was a problem hiding this comment.
I'm wondering if the new check should be for event.State.TTL > 0 since event.State.TTL starts as a -1 * time.Second.
There was a problem hiding this comment.
The idea here is that TTL is reset every time the state is updated. As all new states are initialies with -1 this would mean these states would never get a TTL according to clean_inactive. My first idea was to have state.Remove = true as a flag for states that can be removed but it would blow up the change. But this would clearly show the difference between TTL and states that should be removed. TTL = 0 is like an alias for the Removed option and is only set when one of the clean options is reached.
ruflin
removed
the
needs_backport
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Oct 11, 2016
…at states were not directly removed from the registry (elastic#2750) The clean_inactive option was updating the TTL after clean_removed was applied. This lead to the issue that during every run clean_removed updated the state and clean_inactive reset the TTL. In the end removed files were never purged from the registry if both options were used together. * Test added to verify fix * Updated incorrect log message Closes elastic#2646
tsg
pushed a commit
that referenced
this pull request
Oct 12, 2016
…at states were not directly removed from the registry (#2750) (#2754) The clean_inactive option was updating the TTL after clean_removed was applied. This lead to the issue that during every run clean_removed updated the state and clean_inactive reset the TTL. In the end removed files were never purged from the registry if both options were used together. * Test added to verify fix * Updated incorrect log message Closes #2646
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…at states were not directly removed from the registry (elastic#2750) (elastic#2754) The clean_inactive option was updating the TTL after clean_removed was applied. This lead to the issue that during every run clean_removed updated the state and clean_inactive reset the TTL. In the end removed files were never purged from the registry if both options were used together. * Test added to verify fix * Updated incorrect log message Closes elastic#2646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If clean_removed and clean_inactive were used together, states were not directly removed from the registry. The clean_inactive option was updating the TTL after clean_removed was applied. This lead to the issue that during every run clean_removed updated the state and clean_inactive reset the TTL. In the end removed files were never purged from the registry if both options were used together.
Closes #2646