Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAProxy improvements #3003

Merged
merged 2 commits into from Nov 18, 2016

Conversation

Projects
None yet
2 participants
@ruflin
Copy link
Collaborator

commented Nov 15, 2016

Restructure info and stats metricset

  • Review all fields for naming
  • Update docs with new fields

I didn't add dashboards yet. When we add dashboard it might get some more insights if there are some values we need / don't need. That is the reason I kept it experimental.

@ruflin ruflin force-pushed the ruflin:mb-haproxy-improvements branch 3 times, most recently from 7eea26d to 8ee402e Nov 18, 2016

@ruflin ruflin added review and removed in progress labels Nov 18, 2016

@ruflin ruflin force-pushed the ruflin:mb-haproxy-improvements branch from 8ee402e to 93300e4 Nov 18, 2016

HAProxy improvements
Restructure info and stats metricset

@ruflin ruflin force-pushed the ruflin:mb-haproxy-improvements branch from 93300e4 to e88749d Nov 18, 2016

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 18, 2016

jenkins, retest it

@andrewkroh
Copy link
Member

left a comment

LGTM. Without knowing what all those fields mean it's hard to review what makes the most sense in terms of naming and structure, but it appears that it's now more consistent with the other data in Metricbeat.

// As a minimum it must inherit the mb.BaseMetricSet fields, but can be extended with
// additional entries. These variables can be used to persist data or configuration between
// multiple fetch calls.
// MetricSet for haproxy info

This comment has been minimized.

Copy link
@andrewkroh

andrewkroh Nov 18, 2016

Member

Please 🙏 end all godocs with periods. Then no one has to wonder if you forgot to write the end of the sentence. 😼

This comment has been minimized.

Copy link
@ruflin

ruflin Nov 18, 2016

Author Collaborator

done

@andrewkroh andrewkroh merged commit 0c07d91 into elastic:master Nov 18, 2016

3 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@ruflin ruflin deleted the ruflin:mb-haproxy-improvements branch Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.