Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/module/okta: add extended okta.debug_context.debug_data handling #31676

Merged
merged 1 commit into from May 23, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 19, 2022

What does this PR do?

This is the beats cognate for elastic/integrations#3362 which adds additional handling of the debug_context.debug_data object and particularly the risk level field that is in that object.

Why is it important?

This adds important fields for threat risk assessment.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Compare with integrations addition.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.3-candidate labels May 19, 2022
@efd6 efd6 self-assigned this May 19, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 19, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-23T11:34:04.883+0000

  • Duration: 77 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 6242
Skipped 737
Total 6979

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented May 19, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 30961-okta upstream/30961-okta
git merge upstream/main
git push upstream 30961-okta

@mergify
Copy link
Contributor

mergify bot commented May 20, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 30961-okta upstream/30961-okta
git merge upstream/main
git push upstream 30961-okta

@efd6 efd6 marked this pull request as ready for review May 23, 2022 11:33
@efd6 efd6 requested a review from a team as a code owner May 23, 2022 11:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit d0db6a2 into elastic:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3-candidate backport-skip Skip notification from the automated backport with mergify bug enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat][Okta] Parse additonal debug data risk field for Okta module
3 participants