Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTICE file to the packages #3379

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
3 participants
@tsg
Copy link
Collaborator

tsg commented Jan 16, 2017

Added to the home path. Also modifies the generators to include a simple
NOTICE file, which is anyway good practice for Apache licensed projects.

Tested the beat and the metricbeat generators by hand.

Follow up for #3334.

Add NOTICE file to the packages
Added to the home path. Also modifies the generators to include a simple
NOTICE file, which is anyway good practice for Apache licensed projects.

Tested the beat and the metricbeat generators by hand.

@tsg tsg force-pushed the tsg:install_notice_file branch from 1d8ffae to ffd24c8 Jan 16, 2017

@tsg

This comment has been minimized.

Copy link
Collaborator Author

tsg commented Jan 16, 2017

jenkins, package it

@tsg tsg requested review from ruflin and monicasarbu Jan 16, 2017

@ruflin

ruflin approved these changes Jan 16, 2017

@@ -0,0 +1,5 @@
{beat}
Copyright 2017 {full_name}

This comment has been minimized.

Copy link
@ruflin

ruflin Jan 16, 2017

Collaborator

We should introduce {year} here so we have it always up-to-date ;-) Not needed in this PR.

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Jan 16, 2017

Contributor

The year is generated by the script, so you would need to re-run the script every year, at least :)

This comment has been minimized.

Copy link
@ruflin

ruflin Jan 16, 2017

Collaborator

That is even nicer. My change would only set the correct date on the first creation.

@ruflin

This comment has been minimized.

Copy link
Collaborator

ruflin commented Jan 16, 2017

@ruflin ruflin merged commit f3352eb into elastic:master Jan 16, 2017

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Commit author is a member of Elasticsearch
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

tsg added a commit to tsg/beats that referenced this pull request Jan 16, 2017

Add NOTICE file to the packages (elastic#3379)
Added to the home path. Also modifies the generators to include a simple
NOTICE file, which is anyway good practice for Apache licensed projects.

Tested the beat and the metricbeat generators by hand.
(cherry picked from commit f3352eb)

@tsg tsg removed the needs_backport label Jan 16, 2017

monicasarbu added a commit that referenced this pull request Jan 16, 2017

Backport 3334 & 3379 to 5.2: Notice file (#3380)
* Add NOTICE file for Beats (#3334)

* Python script to generate the NOTICE file

The script receives a directory and searches for all the all vendor subdirectories in order to extract copyright
information about the 3rd party libraries that are used. The NOTICE file is
generated in the current directory.

For each 3rd party library, the following rules are used:
- If the library has apache license, and if NOTICE file is present, include that text in  the NOTICE file.
- If the library has MIT, ISC or BSD license, include the whole copyright block in NOTICE file (meaning copyright + license)

* Accept also 3rd party libraries with less than 3 directories

(cherry picked from commit e2aaa38)

* Add NOTICE file to the packages (#3379)

Added to the home path. Also modifies the generators to include a simple
NOTICE file, which is anyway good practice for Apache licensed projects.

Tested the beat and the metricbeat generators by hand.
(cherry picked from commit f3352eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.