Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heartbeat sample configuration files #3401

Merged
merged 1 commit into from Jan 19, 2017

Conversation

urso
Copy link

@urso urso commented Jan 18, 2017

  • add banner to configuration files
  • use a small sample config in heartbeat.yml only.

@urso urso added needs_backport PR is waiting to be backported to other branches. review labels Jan 18, 2017
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comments. Besides that looks good to me. I think what is most important is that if some just runs the binary, it works out of the box and this seems to be the case with icmp only.

@@ -1,191 +1,20 @@
################### Heartbeat Configuration Example #########################

# This file is an example configuration file highlighting only some common options.
# The heartbeat.full.file file in the same directory contains all the supported options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heartbeat.full.yml (instead of file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@urso
Copy link
Author

urso commented Jan 18, 2017

Left a minor comments. Besides that looks good to me. I think what is most important is that if some just runs the binary, it works out of the box and this seems to be the case with icmp only.

hmm... icmp might not work on windows though

@urso urso force-pushed the enh/heartbeat-config-files branch from 484b57f to c4f1b83 Compare January 18, 2017 16:21
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets think about the Windows part in a second stage. LGTM. Waiting on green.


# Configure task schedule using cron-like syntax
schedule: '*/5 * * * * * *' # exactly every 5 seconds like 10:00:00, 10:00:05, ...
- type: icmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you were saying the icmp is not available on Windows, right? I'd like the default configuration to work by default on all platforms. Plus I find the case of HTTP monitoring more natural for Heartbeat.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we switch to http as default, the discussion comes up which port should be monitored by default. In the default setup we expect 9200 to be available (ES). Current default is 80.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for 9200 port by default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will go with http + 9200 for minimal config

@tsg
Copy link
Contributor

tsg commented Jan 18, 2017

jenkins, package it

- add banner to configuration files
- use a small sample config in heartbeat.yml only.
@urso urso force-pushed the enh/heartbeat-config-files branch from c4f1b83 to d18bdda Compare January 19, 2017 13:44
@tsg tsg merged commit 6429a09 into elastic:master Jan 19, 2017
tsg pushed a commit to tsg/beats that referenced this pull request Jan 19, 2017
- add banner to configuration files
- use a small sample config in heartbeat.yml only.
(cherry picked from commit 6429a09)
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Jan 19, 2017
@urso urso deleted the enh/heartbeat-config-files branch February 19, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants