Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Apply close_timeout also when output is blocked #3511
It is important to note, that this closes the file handler but NOT the harvester. This is important as the closing of the harvester requires a state update to set
Previously the internal state of a harvester was updated when the event was created. This could lead to the issue that in case an event was not sent but the state update went through, that an event would be missing. This is now prevent by overwriting the internal state only when the event was successfully sent.
The done channels from prospector and harvester are renamed to be more obvious which one belongs to what: h.done -> h.prospectorDone, h.harvestDone -> h.done. As the harvester channel is close with the
This PR does not solve the problem related to reloading and stopping a harvester mentioned in #3511 (comment) related to reloading. This will be done in a follow up PR.
In a call with Steffen we came to the following conclusions:
changed the title from
Prototype: Introduce close_send_timeout
Apply close_timeout also when output is blocked
Feb 6, 2017
UPDATE: Problem should be fixed.
This cause a race condition on windows. Not sure yet where it is exactly happening: