New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboards to the list of configuration options #3551

Merged
merged 1 commit into from Feb 7, 2017

Conversation

Projects
None yet
3 participants
@monicasarbu
Contributor

monicasarbu commented Feb 7, 2017

Add dashboards to the list of possible configuration options.

@monicasarbu

This comment has been minimized.

Show comment
Hide comment
@monicasarbu

monicasarbu Feb 7, 2017

Contributor

@andrewkroh Can you please have a look at this PR?

Contributor

monicasarbu commented Feb 7, 2017

@andrewkroh Can you please have a look at this PR?

@andrewkroh

LGTM. We should probably remove the strict validation from Winlogbeat at some point.

Originally when it was first added there were only a handful of possible top-level options but now there are a lot more and it's hard to maintain this list.

@tsg

This comment has been minimized.

Show comment
Hide comment
@tsg

tsg Feb 7, 2017

Collaborator

Winlogbeat tests have passed.

Collaborator

tsg commented Feb 7, 2017

Winlogbeat tests have passed.

@tsg tsg merged commit 60e7999 into elastic:master Feb 7, 2017

2 of 4 checks passed

default Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment