Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all missing plugins in the same err message #3706

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
3 participants
@tsg
Copy link
Collaborator

commented Mar 1, 2017

A drawback of the error handling in #3676 was that if more than one
plugin is missing in ES, the error only reported the first one. This means
that the user might go through an annoying trial and error cycle.

To solve this, we make the modules declare their processor requirements
in the manifest.yml file and we compare them with the available processors
from calling /_nodes/ingest.

This is how the error looks like:

Exiting: Error loading pipeline for fileset apache2/access: This module requires the following
Elasticsearch plugins: ingest-user-agent, ingest-geoip. You can install them by running the
following commands on all the Elasticsearch nodes:
    sudo bin/elasticsearch-plugin install ingest-user-agent
    sudo bin/elasticsearch-plugin install ingest-geoip

In case the module author doesn't declare the required processor plugins, the
error handling in #3676 still applies.

Note: i opened in 5.3 to save time. Needs to be cherry-picked to master.

Show all missing plugins in the same err message
A drawback of the error handling in #3676 was that if more than one
plugin is missing in ES, the error only reported the first one. This means
that the user might go through an annoying trial and error cycle.

To solve this, we make the modules declare their processor requirements
in the `manifest.yml` file and we compare them with the available processors
from calling `/_nodes/ingest`.

In case the module author doesn't declare the required processor plugins, the
error handling in #3676 still applies.

@ruflin ruflin merged commit ddba3f1 into elastic:5.3 Mar 2, 2017

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

tsg added a commit to tsg/beats that referenced this pull request Mar 2, 2017

Show all missing plugins in the same err message (elastic#3706)
A drawback of the error handling in elastic#3676 was that if more than one
plugin is missing in ES, the error only reported the first one. This means
that the user might go through an annoying trial and error cycle.

To solve this, we make the modules declare their processor requirements
in the `manifest.yml` file and we compare them with the available processors
from calling `/_nodes/ingest`.

In case the module author doesn't declare the required processor plugins, the
error handling in elastic#3676 still applies.
(cherry picked from commit ddba3f1)

@tsg tsg removed the needs_backport label Mar 2, 2017

ruflin added a commit that referenced this pull request Mar 3, 2017

Show all missing plugins in the same err message (#3706) (#3711)
A drawback of the error handling in #3676 was that if more than one
plugin is missing in ES, the error only reported the first one. This means
that the user might go through an annoying trial and error cycle.

To solve this, we make the modules declare their processor requirements
in the `manifest.yml` file and we compare them with the available processors
from calling `/_nodes/ingest`.

In case the module author doesn't declare the required processor plugins, the
error handling in #3676 still applies.
(cherry picked from commit ddba3f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.