New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove convert old states code #3767

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
2 participants
@ruflin
Collaborator

ruflin commented Mar 17, 2017

Filebeat 1.x had a different registry format from 5.x. So a conversion of the format happened. This code is now removed for 6.0 as the upgrade path to 6.0 is from 5.0.

The code caused some issues in the past so it is better to not have it in anymore.

@ruflin ruflin referenced this pull request Mar 21, 2017

Closed

Remove deprecated features in master branch #3782

5 of 5 tasks complete
@@ -20,6 +20,7 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff]
*Filebeat*
- Always use absolute path for event and registry. This can lead to issues when relative paths were used before. {pull}3328[3328]
- Remove code to convert states from 1.x.

This comment has been minimized.

@tsg

tsg Mar 22, 2017

Collaborator

Link to PR please.

This comment has been minimized.

@tsg

tsg Mar 22, 2017

Collaborator

Ah, still has in in progress, nevermind :)

This comment has been minimized.

@ruflin

ruflin Mar 22, 2017

Collaborator

good you mentioned it, would have forgotten otherwise ;-)

Remove convert old states code
Filebeat 1.x had a different registry format from 5.x. So a conversion of the format happened. This code is now removed for 6.0 as the upgrade path to 6.0 is from 5.0.

The code caused some issues in the past so it is better to not have it in anymore.

@ruflin ruflin added review and removed in progress labels Mar 22, 2017

@tsg tsg merged commit fc15b80 into elastic:master Mar 22, 2017

4 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@ruflin ruflin deleted the ruflin:remove-convert-old-states branch May 10, 2017

@tsg tsg referenced this pull request Jul 24, 2017

Closed

Document breaking changes in 6.0 #4737

28 of 28 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment