Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov config #3906

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
@ruflin
Copy link
Collaborator

commented Apr 4, 2017

Codecov will report coverage for the patch and for the project based on the pull request. In case the overall coverage drops by more then 0.5% the pull request will fail. It is still possible to have pull requests without tests which will not fail because the overall coverage did not change too much.

@ruflin ruflin requested a review from tsg Apr 4, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 5, 2017

jenkins, retest it

@tsg

tsg approved these changes Apr 5, 2017

Copy link
Collaborator

left a comment

LGTM, left two questions.

codecov.yml Outdated
default:
target: auto
# Overall coverage should never drop more then 1%
threshold: 0.5

This comment has been minimized.

Copy link
@tsg

tsg Apr 5, 2017

Collaborator

Comment above is wrong, says 1% :)

This comment has been minimized.

Copy link
@ruflin

ruflin Apr 5, 2017

Author Collaborator

argh, updated the value and not the comment ...

target: auto
threshold: 0.1
# Allows PRs without tests, overall stats count
threshold: 100

This comment has been minimized.

Copy link
@tsg

tsg Apr 5, 2017

Collaborator

Does this mean this check will always be green, because threshlod is 100?

This comment has been minimized.

Copy link
@ruflin

ruflin Apr 5, 2017

Author Collaborator

Exactly. Patch level check will always be green. Otherwise if 1 code line is added which is not covered, it would have 0% coverage.

Update codecov config
Codecov will report coverage for the patch and for the project based on the pull request. In case the overall coverage drops by more then 0.5% the pull request will fail. It is still possible to have pull requests without tests which will not fail because the overall coverage did not change too much.

@ruflin ruflin force-pushed the ruflin:codecov-adjustments branch from d1e802e to 3df95f2 Apr 5, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 5, 2017

Update version pushed.

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 6, 2017

jenkins, retest it

@tsg tsg merged commit fcc02f8 into elastic:master Apr 6, 2017

6 checks passed

CLA Commit author has signed the CLA
Details
codecov/patch Coverage not affected when comparing e73bb6b...3df95f2
Details
codecov/project 65.53% (-0.01%) compared to e73bb6b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Update codecov config (elastic#3906)
Codecov will report coverage for the patch and for the project based on the pull request. In case the overall coverage drops by more then 0.5% the pull request will fail. It is still possible to have pull requests without tests which will not fail because the overall coverage did not change too much.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.