Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add new MetricSet interfaces for Module Developers #3908
This PR adds new interfaces for MetricSet developers. These interfaces provided additional flexibility for MetricSet implementations. The new interfaces are:
Not all usage of the interfaces is 100% clear to me yet, but I assume they will get answered as soon as we have the first implementation.
For the ReportingFetcher: Wouldn't it be enough to have
Fetch() (common.MapStr, error) as an interface? How will the additional meta data and errors used? I'm aware you are no big fan of having a "special" Error object but perhaps something like this could be used here?
I would like to make it clear from the godocs. What would improve your understanding? More docs on the MetricSet types? An example for for each MetricSet type (
No, that interface wouldn't be sufficient because you cannot report multiple events. Nor can you send data with an error.
Maybe only a portion of the metrics were able to be collected due to an error. You can report the metrics you have available and also report the problem that occurred. Perhaps @urso had a different vision for
@andrewkroh Ok for me to move forward on this. We definitively need some of these new capabilities for upcoming Modules. I'm still not 100% sure which interfaces we should keep in the end but time will show.