Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing panic on prometheus collector when label has , #3947

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
4 participants
@vjsamuel
Copy link
Contributor

commented Apr 7, 2017

Fixes #3946

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 7, 2017

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine

This comment has been minimized.

Copy link

commented Apr 7, 2017

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@vjsamuel vjsamuel force-pushed the vjsamuel:fix_prometheus_scrape_panic branch 3 times, most recently from 01ea11b to fb37e60 Apr 7, 2017

@vjsamuel vjsamuel force-pushed the vjsamuel:fix_prometheus_scrape_panic branch from fb37e60 to 1a3e1ed Apr 7, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Apr 7, 2017

jenkins, test it

@ruflin

ruflin approved these changes Apr 7, 2017

Copy link
Collaborator

left a comment

Waiting for green.

@ruflin ruflin merged commit e5dcd4d into elastic:master Apr 7, 2017

5 checks passed

CLA Commit author has signed the CLA
Details
codecov/patch 85.71% of diff hit (target 65.34%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@vjsamuel vjsamuel deleted the vjsamuel:fix_prometheus_scrape_panic branch Apr 7, 2017

@tsg tsg added the v5.4.0 label Apr 12, 2017

tsg added a commit to tsg/beats that referenced this pull request Apr 12, 2017

@tsg tsg removed the needs_backport label Apr 12, 2017

ruflin added a commit that referenced this pull request Apr 12, 2017

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.