New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error to error.message #3987

Merged
merged 1 commit into from Apr 12, 2017

Conversation

Projects
None yet
2 participants
@ruflin
Collaborator

ruflin commented Apr 11, 2017

Currently error message in metricbeat are written into the error field. In heartbeat error.message is used. To unify the error structure and allow in the future to support things like error.code and others inside the error, error is changed to error.message.

Currently internally all error are just written to error.message. In future PR's an internal logic should be added to support error.code and others so Metricsets, Prospectors etc. can make use of it.

Changes

  • Change error to error.message
  • Move error mappings from heartbeat to libbeat

Closes #3951

Change error to error.message
Currently error message in metricbeat are written into the `error` field. In heartbeat `error.message` is used. To unify the error structure and allow in the future to support things like `error.code` and others inside the error, `error` is changed to `error.message`.

Currently internally all `error` are just written to `error.message`. In future PR's an internal logic should be added to support `error.code` and others so  Metricsets, Prospectors etc. can make use of it.

Changes

* Change `error` to `error.message`
* Move error mappings from heartbeat to libbeat

Closes #3951

@ruflin ruflin removed the in progress label Apr 12, 2017

@ruflin ruflin requested a review from tsg Apr 12, 2017

@tsg

tsg approved these changes Apr 12, 2017

LGTM.

@tsg tsg merged commit c27aab4 into elastic:master Apr 12, 2017

6 checks passed

CLA Commit author has signed the CLA
Details
codecov/patch 100% of diff hit (target 64.31%)
Details
codecov/project 64.31% (+<.01%) compared to a5cc6a2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@ruflin ruflin deleted the ruflin:error-message branch Apr 12, 2017

@tsg tsg referenced this pull request Jul 24, 2017

Closed

Document breaking changes in 6.0 #4737

28 of 28 tasks complete

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Change error to error.message (elastic#3987)
Currently error message in metricbeat are written into the `error` field. In heartbeat `error.message` is used. To unify the error structure and allow in the future to support things like `error.code` and others inside the error, `error` is changed to `error.message`.

Currently internally all `error` are just written to `error.message`. In future PR's an internal logic should be added to support `error.code` and others so  Metricsets, Prospectors etc. can make use of it.

Changes

* Change `error` to `error.message`
* Move error mappings from heartbeat to libbeat

Closes elastic#3951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment