Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about editorconfig to CONTRIBUTING.md #4136

Merged
merged 1 commit into from May 2, 2017

Conversation

Projects
None yet
3 participants
@ruflin
Copy link
Collaborator

ruflin commented Apr 28, 2017

No description provided.

@@ -72,6 +72,10 @@ Packetbeat:
Some of the Beats might have extra development requirements, in which case you'll find a
CONTRIBUTING.md file in the Beat directory.

We use an [EditorConfig](http://editorconfig.org/) file in the beats repository to standardise
how different editors use whitespaces etc. in our files. Most popular editors have a

This comment has been minimized.

Copy link
@dedemorton

dedemorton Apr 28, 2017

Contributor

Avoid using "etc" because it can sometimes be a problem when the doc gets translated. How about being more specific?

...how different editors handle whitespace, line endings, and other coding styles in our files... (UPDATED)

This comment has been minimized.

Copy link
@dedemorton

dedemorton Apr 28, 2017

Contributor

I guess tabs are technically whitespace...hehe. but I think you see the point...

This comment has been minimized.

Copy link
@ruflin

ruflin May 1, 2017

Author Collaborator

adjusted.

@@ -72,6 +72,10 @@ Packetbeat:
Some of the Beats might have extra development requirements, in which case you'll find a
CONTRIBUTING.md file in the Beat directory.

We use an [EditorConfig](http://editorconfig.org/) file in the beats repository to standardise
how different editors use whitespaces etc. in our files. Most popular editors have a
[plugin](http://editorconfig.org/#download) for EditorConfig and we strongly recommend you to install it.

This comment has been minimized.

Copy link
@dedemorton

dedemorton Apr 28, 2017

Contributor

"we strongly recommend that you install it..."

This comment has been minimized.

Copy link
@ruflin

ruflin May 1, 2017

Author Collaborator

adjusted

@ruflin ruflin force-pushed the ruflin:editorconfig-contributing branch from 07d3009 to dc69938 May 1, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

ruflin commented May 1, 2017

@dedemorton New version pushed.

@dedemorton

This comment has been minimized.

Copy link
Contributor

dedemorton commented May 1, 2017

LGTM

@tsg tsg merged commit 3ffbeb2 into elastic:master May 2, 2017

3 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.