New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubernetes indexers/matchers pluggable #4151

Merged
merged 1 commit into from May 1, 2017

Conversation

Projects
None yet
4 participants
@vjsamuel
Contributor

vjsamuel commented Apr 30, 2017

This PR makes kubernetes indexers/matchers pluggable so that users can write their own plugins and plug them into stock/custom beats

@elasticmachine

This comment has been minimized.

elasticmachine commented Apr 30, 2017

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine

This comment has been minimized.

elasticmachine commented Apr 30, 2017

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@ruflin

This comment has been minimized.

Collaborator

ruflin commented May 1, 2017

jenkins, test it

@ruflin

ruflin approved these changes May 1, 2017

LGTM.

@vjsamuel Could you share some details on what other indexer / matcher you have in mind?

@vjsamuel

This comment has been minimized.

Contributor

vjsamuel commented May 1, 2017

we have internal indexers that we would want to generate hash values of the dimensions and store them along with the kubernetes metadata. having a plugin interface makes it easier to maintain this code outside the beats repository.

@ruflin

This comment has been minimized.

Collaborator

ruflin commented May 1, 2017

jenkins, retest it

@ruflin

This comment has been minimized.

Collaborator

ruflin commented May 1, 2017

Merging as build seems to be all fine except for pushing the artifacts.

@ruflin ruflin merged commit d47c55a into elastic:master May 1, 2017

5 of 6 checks passed

default Build finished.
Details
CLA Commit author has signed the CLA
Details
codecov/patch 11.53% of diff hit (within 100% threshold of 64.63%)
Details
codecov/project 64.59% (-0.05%) compared to ea763e2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vjsamuel vjsamuel deleted the vjsamuel:kubernetes_plugins branch May 2, 2017

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment