Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-deterministic vsphere datastore tests #4220

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
2 participants
@andrewkroh
Copy link
Member

andrewkroh commented May 5, 2017

The data used in the test appears to be simulated using df -k. So the assertions needed to be less strict.

And on windows, df -k doesn’t exist so the values are 0 which caused a panic due to a panic: runtime error: integer divide by zero.

Failures: https://beats-ci.elastic.co/job/elastic+beats+master+tests/beat=metricbeat,label=linux/251/console

Fix non-deterministic vsphere datastore tests
The data used in the test appears to be simulated using `df -k`. So the assertions needed to be less strict.

And on windows, `df -k` doesn’t exist so the values are 0 which caused a panic due to a `panic: runtime error: integer divide by zero`.

@andrewkroh andrewkroh referenced this pull request May 5, 2017

Merged

Add data.json files for vsphere module. WIP #4209

3 of 4 tasks complete
@ruflin

ruflin approved these changes May 5, 2017

f := find.NewFinder(m.Client, true)
if f == nil {

This comment has been minimized.

Copy link
@ruflin

ruflin May 5, 2017

Collaborator

is this not needed anymore?

This comment has been minimized.

Copy link
@andrewkroh

andrewkroh May 5, 2017

Author Member

I looked at the implementation in find.NewFinder() and it's not possible for it to return nil.

@ruflin ruflin merged commit d73544e into elastic:master May 5, 2017

6 checks passed

CLA Commit author has signed the CLA
Details
codecov/patch 87.5% of diff hit (target 64.83%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +22.66% compared to 9344f75
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@andrewkroh andrewkroh deleted the andrewkroh:bugfix/vsphere-datastore-test branch Jul 5, 2017

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Fix non-deterministic vsphere datastore tests (elastic#4220)
The data used in the test appears to be simulated using `df -k`. So the assertions needed to be less strict.

And on windows, `df -k` doesn’t exist so the values are 0 which caused a panic due to a `panic: runtime error: integer divide by zero`.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Fix non-deterministic vsphere datastore tests (elastic#4220)
The data used in the test appears to be simulated using `df -k`. So the assertions needed to be less strict.

And on windows, `df -k` doesn’t exist so the values are 0 which caused a panic due to a `panic: runtime error: integer divide by zero`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.