Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template test cleanup #4357

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
2 participants
@andrewkroh
Copy link
Member

commented May 19, 2017

Make the test fail gracefully. It was panic’ing if fields.yml was not found. In general avoid assert.NoError() unless the test should continue after the error.

https://beats-ci.elastic.co/job/elastic+beats+master+tests-windows/16/beat=libbeat,label=windows/testReport/(root)/template/TestGenerateTemplate/

Template test cleanup
Make the test fail gracefully. It was panic’ing if fields.yml was not found. In general avoid assert.NoError() unless the test should continue after the error.

@ruflin ruflin merged commit 84dcac2 into elastic:master May 19, 2017

6 of 7 checks passed

beats-ci Build finished.
Details
CLA Commit author has signed the CLA
Details
codecov/patch Coverage not affected when comparing 3051a31...7f5f75f
Details
codecov/project 63.12% (+0.01%) compared to 3051a31
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

vjsamuel added a commit to vjsamuel/beats that referenced this pull request May 22, 2017

Template test cleanup (elastic#4357)
Make the test fail gracefully. It was panic’ing if fields.yml was not found. In general avoid assert.NoError() unless the test should continue after the error.

@andrewkroh andrewkroh deleted the andrewkroh:bugfix/load-test-cleanup branch Jul 5, 2017

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Template test cleanup (elastic#4357)
Make the test fail gracefully. It was panic’ing if fields.yml was not found. In general avoid assert.NoError() unless the test should continue after the error.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Template test cleanup (elastic#4357)
Make the test fail gracefully. It was panic’ing if fields.yml was not found. In general avoid assert.NoError() unless the test should continue after the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.