Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused packages from vendor directory #4366

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@ruflin
Copy link
Collaborator

commented May 22, 2017

Run govendor remove +unused

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented May 22, 2017

I expect this to potentially break packaging, so packaging must also be tested.

@ruflin ruflin force-pushed the ruflin:remove-unused-libs branch from 20fa8b0 to 17a73b7 May 22, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented May 22, 2017

jenkins, retest it

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented May 22, 2017

jenkins, package it

@ruflin ruflin added review and removed in progress labels May 22, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented May 22, 2017

Seems like packaging is also ok. Set it to review.

@andrewkroh andrewkroh merged commit e66e185 into elastic:master May 22, 2017

6 of 7 checks passed

codecov/project 55.41% (-7.68%) compared to 8fb1cf9
Details
CLA Commit author has signed the CLA
Details
beats-ci Build finished.
Details
codecov/patch Coverage not affected when comparing 8fb1cf9...17a73b7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.