Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve `make notice` to work on libs not 3 dirs long #4380

Merged
merged 2 commits into from May 23, 2017

Conversation

Projects
None yet
3 participants
@tsg
Copy link
Collaborator

commented May 23, 2017

Did this refactoring in preparation for a change that adds the version in,
but opening it as its own PR so we can verify the diff. There were a few
libs that were not exactly "3 dirs long".

Improve `make notice` to work on libs not 3 dirs long
Did this refactoring in preparation for a change that adds the version in,
but opening it as its own PR so we can verify the diff. There were a few
libs that were not exactly "3 dirs long".

@tsg tsg added :Infra review labels May 23, 2017

@tsg tsg requested a review from monicasarbu May 23, 2017

@ruflin

ruflin approved these changes May 23, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2017

@tsg Interesting, it seems make check gets a different notice file ...

@tsg

This comment has been minimized.

Copy link
Collaborator Author

commented May 23, 2017

Ah, it has something to do with libraries that show up multiple times. Investigating.

@tsg

This comment has been minimized.

Copy link
Collaborator Author

commented May 23, 2017

This last commit sort of fixes the effect of a bigger issue: if there are multiple LICENSE files in the same library (for example, mgo has LICENSE and LICENSE.libyaml), we only include one of them. Correct would be to add them all, but that's for another PR.

@ruflin ruflin merged commit e018722 into elastic:master May 23, 2017

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Commit author is a member of Elasticsearch
Details
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Improve `make notice` to work on libs not 3 dirs long (elastic#4380)
Did this refactoring in preparation for a change that adds the version in,
but opening it as its own PR so we can verify the diff. There were a few
libs that were not exactly "3 dirs long".

* If there are multiple LICENSE files in the same lib, read them in order

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Improve `make notice` to work on libs not 3 dirs long (elastic#4380)
Did this refactoring in preparation for a change that adds the version in,
but opening it as its own PR so we can verify the diff. There were a few
libs that were not exactly "3 dirs long".

* If there are multiple LICENSE files in the same lib, read them in order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.