Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IP port indexer constructor public #4434

Merged
merged 1 commit into from Jun 1, 2017

Conversation

@vjsamuel
Copy link
Contributor

commented Jun 1, 2017

NewIpPortIndexer() has scope to be used and extended by other beats. We could make the method public like all the other indexers

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2017

Can one of the admins verify this patch?

@vjsamuel vjsamuel force-pushed the vjsamuel:make_ip_port_indexer_public branch from bd910d4 to da56981 Jun 1, 2017

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@vjsamuel vjsamuel changed the title Making IP port indexer constructor public Make IP port indexer constructor public Jun 1, 2017

@tsg

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2017

jenkins, test it

@exekias
exekias approved these changes Jun 1, 2017
Copy link
Member

left a comment

LGTM, I'll check what's going on with tests, but seems unrelated to this PR

@exekias exekias merged commit 889f7be into elastic:master Jun 1, 2017

6 checks passed

CLA Commit author has signed the CLA
Details
beats-ci Build finished.
Details
codecov/patch 100% of diff hit (target 58.24%)
Details
codecov/project 63.11% (+4.87%) compared to 08c2542
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017
athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

@vjsamuel vjsamuel deleted the vjsamuel:make_ip_port_indexer_public branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.