Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save a single dashboard per json file #4614

Merged
merged 2 commits into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@monicasarbu
Copy link
Contributor

commented Jul 5, 2017

Currently, in case the dashboards are linked together, all the dashboards are saved in a single json file. If one changes, then all the dashboards are affected and need to be exported. To make it easier to update/change a single dashboard, this PR saves a dashboard in a single JSON file.

@monicasarbu monicasarbu force-pushed the monicasarbu:single_dashboard_per_json branch 2 times, most recently from 035b2cb to d682e9e Jul 5, 2017

Save each Kibana dashboard as separate json file to be easier to upgr…
…ade.

Changes to the export-dashboards:
- The export-dashboards script doesn't receive a list of dashboards IDs to export, and a single ID
- In case multiple dashboards are associated with a module, the export-dashboards script can receive a yml file with
all the dashboards. Each dashboard is represented by an id and the json file where to save the dashboard.

@monicasarbu monicasarbu force-pushed the monicasarbu:single_dashboard_per_json branch from b42c59c to 7d9bc74 Jul 5, 2017

@monicasarbu monicasarbu added review and removed in progress labels Jul 5, 2017

@tsg

tsg approved these changes Jul 5, 2017

Copy link
Collaborator

left a comment

LGTM.

@tsg tsg merged commit 1fa64ba into elastic:master Jul 5, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Commit author is a member of Elasticsearch
Details
beats-ci Build finished.
Details
@@ -0,0 +1,12 @@
dashboards:

This comment has been minimized.

Copy link
@ruflin

ruflin Jul 11, 2017

Collaborator

@tsg @monicasarbu Should we call this file dashboards.yml? I was at first confused what this file is about.

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Jul 14, 2017

Author Contributor

@ruflin My idea was that we might want to include other configurations here as well in the future. I agree to rename it to dashboards.yml and we can change the name to something else when we have other configurations to add to it.

This comment has been minimized.

Copy link
@ruflin

ruflin Jul 14, 2017

Collaborator

ah, I see. I kind of like the idea. We should make sure that these "local" config options are always overwritable in a global config file like we have the the module config options. Probably not that relevant for dashboards though.

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Save a single dashboard per json file (elastic#4614)
* Save each Kibana dashboard as separate json file to be easier to upgrade.

Changes to the export-dashboards:
- The export-dashboards script doesn't receive a list of dashboards IDs to export, and a single ID
- In case multiple dashboards are associated with a module, the export-dashboards script can receive a yml file with
all the dashboards. Each dashboard is represented by an id and the json file where to save the dashboard.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Save a single dashboard per json file (elastic#4614)
* Save each Kibana dashboard as separate json file to be easier to upgrade.

Changes to the export-dashboards:
- The export-dashboards script doesn't receive a list of dashboards IDs to export, and a single ID
- In case multiple dashboards are associated with a module, the export-dashboards script can receive a yml file with
all the dashboards. Each dashboard is represented by an id and the json file where to save the dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.