Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable logging for module command tests #4645

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Projects
None yet
2 participants
@andrewkroh
Copy link
Member

andrewkroh commented Jul 10, 2017

Disable logging for the tests that check for specific output that spans multiple lines. The logger output was being interleaved with the output from the module commands which could cause the test to fail. For example,

Enabled:
enabled

Disabled:
2017/07/10 20:22:39.125125 metrics.go:23: INFO Metrics logging every 30s
disabled
disabled2
Disable logging for module command tests
Disable logging for the tests that check for specific output that spans multiple lines. The logger output was being interleaved with the output from the module commands which could cause the test to fail. For example,

    Enabled:
    enabled

    Disabled:
    2017/07/10 20:22:39.125125 metrics.go:23: INFO Metrics logging every 30s
    disabled
    disabled2

@andrewkroh andrewkroh requested a review from exekias Jul 10, 2017

@exekias
Copy link
Member

exekias left a comment

WFG

@exekias exekias merged commit d030234 into elastic:master Jul 10, 2017

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Commit author has signed the CLA
Details
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Disable logging for module command tests (elastic#4645)
Disable logging for the tests that check for specific output that spans multiple lines. The logger output was being interleaved with the output from the module commands which could cause the test to fail. For example,

    Enabled:
    enabled

    Disabled:
    2017/07/10 20:22:39.125125 metrics.go:23: INFO Metrics logging every 30s
    disabled
    disabled2

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Disable logging for module command tests (elastic#4645)
Disable logging for the tests that check for specific output that spans multiple lines. The logger output was being interleaved with the output from the module commands which could cause the test to fail. For example,

    Enabled:
    enabled

    Disabled:
    2017/07/10 20:22:39.125125 metrics.go:23: INFO Metrics logging every 30s
    disabled
    disabled2

@andrewkroh andrewkroh deleted the andrewkroh:bugfix/module-tests branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.