Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clean target from Metricbeat #4646

Merged
merged 1 commit into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@andrewkroh
Copy link
Member

andrewkroh commented Jul 10, 2017

The clean target was removing files that are checked into the repo.
The tasks that generate the files are responsible for cleaning the old
files before generating the new ones so the custom clean target is
not required.

Remove clean target from Metricbeat
The clean target was removing files that are checked into the repo.
The tasks that generate them are responsible for cleaning the old
files before generating the new ones so the custom clean target is
not required.

@andrewkroh andrewkroh added the review label Jul 10, 2017

@ruflin

This comment has been minimized.

Copy link
Collaborator

ruflin commented Jul 11, 2017

I remember I wanted to go the other direction in the past so that all the update tasks depend on the clean, but that cause other issues. If I remember correctly I didn't want to require update which depends on python to get a clean repo. But I see the potential confusion with missing files.

@ruflin ruflin merged commit 5b4430f into elastic:master Jul 11, 2017

6 checks passed

CLA Commit author has signed the CLA
Details
beats-ci Build finished.
Details
codecov/patch Coverage not affected when comparing 340ea07...b35bc12
Details
codecov/project 62.93% (+<.01%) compared to 340ea07
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Remove clean target from Metricbeat (elastic#4646)
The clean target was removing files that are checked into the repo.
The tasks that generate them are responsible for cleaning the old
files before generating the new ones so the custom clean target is
not required.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Remove clean target from Metricbeat (elastic#4646)
The clean target was removing files that are checked into the repo.
The tasks that generate them are responsible for cleaning the old
files before generating the new ones so the custom clean target is
not required.

@andrewkroh andrewkroh deleted the andrewkroh:bugfix/metricbeat-clean branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.