New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added breaking changes doc for 6.0 #4760

Merged
merged 2 commits into from Aug 10, 2017

Conversation

Projects
None yet
4 participants
@tsg
Collaborator

tsg commented Jul 26, 2017

Part of #4737.

Note that I didn't repeat everything from the release notes, but I just highlighted the things that are more likely to cause issues. See #4737 for short motivations on each item.

@urso Can you review the Spooler removal part, please?

@dedemorton Let me know please if the overall structure makes sense, happy to consider alternatives.

@dedemorton

This comment has been minimized.

Contributor

dedemorton commented Jul 26, 2017

The overall structure makes sense. It seems a little odd to have the breaking changes for 5.0 in this document, tho, since we're duplicating what we have in the 5.0 docs.

@tsg

This comment has been minimized.

Collaborator

tsg commented Jul 27, 2017

Yeah, it's probably better to remove them. Will do.

- `publish_async`
- `idle_timeout`
- `queue_size`
- `bulk_queue_size`

This comment has been minimized.

@urso

urso Jul 27, 2017

Collaborator

naming:

  • these settings live in filebeat namespace and are used like this on reference configs: filebeat.spool_size, filebeat.publish_async and filebeat.idle_timeout
  • these settings are 'global': queue_size and bulk_max_size.

tsg added some commits Jul 26, 2017

Added breaking changes doc for 6.0
Part of #4737, but there are some TODOs left.
Add section for multiple outputs
Also, addressed commits and removed the 5.0 breaking changes.

@monicasarbu monicasarbu merged commit 6c5f3b2 into elastic:master Aug 10, 2017

4 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/project 58.35% (-4.07%) compared to af3ecf9
Details
CLA Commit author is a member of Elasticsearch
Details
beats-ci Build finished.
Details
codecov/patch Coverage not affected when comparing af3ecf9...e61146b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

dedemorton added a commit to dedemorton/beats that referenced this pull request Aug 14, 2017

Added breaking changes doc for 6.0 (elastic#4760)
* Added breaking changes doc for 6.0

Part of elastic#4737, but there are some TODOs left.

* Add section for multiple outputs

Also, addressed commits and removed the 5.0 breaking changes.

dedemorton added a commit that referenced this pull request Aug 18, 2017

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Added breaking changes doc for 6.0 (elastic#4760)
* Added breaking changes doc for 6.0

Part of elastic#4737, but there are some TODOs left.

* Add section for multiple outputs

Also, addressed commits and removed the 5.0 breaking changes.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Added breaking changes doc for 6.0 (elastic#4760)
* Added breaking changes doc for 6.0

Part of elastic#4737, but there are some TODOs left.

* Add section for multiple outputs

Also, addressed commits and removed the 5.0 breaking changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment