Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pod name indexer to use both namespace, pod name to frame index key #4775

Merged
merged 2 commits into from Jul 31, 2017

Conversation

vjsamuel
Copy link
Contributor

Today we use only pod name in the index key for pod name indexer. With the advent of stateful sets, users can now spin up pods with consistent names like zookeeper-1 on multiple namespaces which can cause collision very easily. Hence it is mandatory for using namespace/podname as the key for pod name indexer.

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment

@@ -5,6 +5,8 @@ import (

"github.com/stretchr/testify/assert"

"fmt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please move this one next to "testing"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i keep missing this always. done.

@exekias
Copy link
Contributor

exekias commented Jul 27, 2017

jenkins test it please

@exekias
Copy link
Contributor

exekias commented Jul 28, 2017

jenkins test it please

@exekias exekias merged commit 10b73be into elastic:master Jul 31, 2017
@exekias exekias deleted the fix_pod_name_indexer branch July 31, 2017 08:18
@exekias exekias added backport bug v6.0.0-GA needs_backport PR is waiting to be backported to other branches. and removed backport labels Aug 1, 2017
@exekias exekias removed the needs_backport PR is waiting to be backported to other branches. label Aug 17, 2017
exekias pushed a commit to exekias/beats that referenced this pull request Aug 17, 2017
…x key (elastic#4775)

* Fixing pod name indexer to use both namespace, pod name to frame index key

* Adding field pattern matcher to support pod name indexer matching
andrewkroh pushed a commit that referenced this pull request Aug 17, 2017
…x key (#4775)

* Fixing pod name indexer to use both namespace, pod name to frame index key

* Adding field pattern matcher to support pod name indexer matching
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…x key (elastic#4775)

* Fixing pod name indexer to use both namespace, pod name to frame index key

* Adding field pattern matcher to support pod name indexer matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants