Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitor.name being empty by default #4856

Merged
merged 2 commits into from Aug 9, 2017

Conversation

Projects
None yet
3 participants
@urso
Copy link
Collaborator

commented Aug 9, 2017

Resolve #4852

  • Fixes the monitor.name field default to monitor.type if not configured
  • Update HTTP dashboards to filter on monitor.type, which will always be http for all HTTP related monitors.

@urso urso force-pushed the urso:fix/heartbeat-monitor-name branch from 7ed2f0c to 481abe1 Aug 9, 2017

@urso urso changed the title [WIP] Fix monitor.name being empty by default Fix monitor.name being empty by default Aug 9, 2017

@urso urso added review and removed in progress labels Aug 9, 2017

@monicasarbu

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2017

@urso Great, waiting for green.

@andrewkroh andrewkroh merged commit a1031e8 into elastic:master Aug 9, 2017

5 of 6 checks passed

beats-ci Build finished.
Details
CLA Commit author is a member of Elasticsearch
Details
codecov/patch 100% of diff hit (target 58.33%)
Details
codecov/project 62.42% (+4.08%) compared to 0cacffe
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

urso added a commit to urso/beats that referenced this pull request Aug 11, 2017

Fix monitor.name being empty by default (elastic#4856)
* Fix monitor.name being empty by default

* Update dashboards to filter by monitor.type

(cherry picked from commit a1031e8)

@urso urso removed the needs_backport label Aug 11, 2017

tsg added a commit that referenced this pull request Aug 14, 2017

Fix monitor.name being empty by default (#4856) (#4877)
* Fix monitor.name being empty by default
* Update dashboards to filter by monitor.type

(cherry picked from commit a1031e8)

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Fix monitor.name being empty by default (elastic#4856)
* Fix monitor.name being empty by default

* Update dashboards to filter by monitor.type

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Fix monitor.name being empty by default (elastic#4856)
* Fix monitor.name being empty by default

* Update dashboards to filter by monitor.type

@urso urso deleted the urso:fix/heartbeat-monitor-name branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.