New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated _default_ mapping to doc in index templates #4864

merged 1 commit into from Aug 10, 2017


None yet
3 participants

kvch commented Aug 10, 2017

_default_ has been changed to doc as seen in this example:

Closes #4840


tsg approved these changes Aug 10, 2017


@@ -128,7 +128,7 @@ func (t *Template) generate(properties common.MapStr, dynamicTemplates []common.
if t.esVersion.IsMajor(2) || t.esVersion.IsMajor(5) {
basicStructure.Put("mappings._default_._all.norms.enabled", false)

This comment has been minimized.


ruflin Aug 10, 2017


@urso We also use doc for all types if we write to indices from 5.x with the ES output? Just want to make sure this also works with older versions of ES.

@tsg tsg merged commit 5a5e210 into elastic:master Aug 10, 2017

6 checks passed

CLA Commit author is a member of Elasticsearch
beats-ci Build finished.
codecov/patch 66.66% of diff hit (target 62.44%)
codecov/project Absolute coverage decreased by -0.06% but relative coverage increased by +4.22% compared to f2d6035
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.


tsg commented Aug 10, 2017

I merged this one, I think it's safe. @ruflin, please speak up if you have any concerns.

@tsg tsg added the needs_backport label Aug 25, 2017

tsg added a commit to tsg/beats that referenced this pull request Aug 25, 2017

@tsg tsg removed the needs_backport label Aug 25, 2017

ruflin added a commit that referenced this pull request Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment