Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing MongoDB config from the `modules.d` folder #4870

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
2 participants
@tsg
Copy link
Collaborator

commented Aug 11, 2017

The command that collected the configurations, used something like
this to list the modules:

ls module | grep -v .go

Problem was, mongodb matched the .go grep, so it was excluded :)

This PR uses find to list the directories.

Fix missing MongoDB config from the `modules.d` folder
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.

@tsg tsg force-pushed the tsg:fix_missing_mongodb_config branch from 8d4f6e0 to 919f1ca Aug 11, 2017

@exekias
Copy link
Member

left a comment

WFG

@exekias exekias merged commit 5adf7e1 into elastic:master Aug 11, 2017

5 of 6 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Commit author is a member of Elasticsearch
Details
beats-ci Build finished.
Details
codecov/patch Coverage not affected when comparing 92ac985...919f1ca
Details
codecov/project 62.4% (+4.12%) compared to 92ac985
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

exekias added a commit to exekias/beats that referenced this pull request Aug 16, 2017

Fix missing MongoDB config from the `modules.d` folder (elastic#4870)
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.

exekias added a commit to exekias/beats that referenced this pull request Aug 16, 2017

Fix missing MongoDB config from the `modules.d` folder (elastic#4870)
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.
(cherry picked from commit 5adf7e1)

@exekias exekias removed the needs_backport label Aug 16, 2017

andrewkroh added a commit that referenced this pull request Aug 16, 2017

Cherry-pick #4870 to 6.0: Fix missing MongoDB config from the `module…
…s.d` folder (#4925)

* Fix missing MongoDB config from the `modules.d` folder (#4870)

The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.

(cherry picked from commit 5adf7e1)

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Fix missing MongoDB config from the `modules.d` folder (elastic#4870)
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Fix missing MongoDB config from the `modules.d` folder (elastic#4870)
The command that collected the configurations, used something like
this to list the modules:

   ls module | grep -v .go

Problem was, `mongodb` matched the `.go` grep, so it was excluded :)

This PR uses `find` to list the directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.