New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system uptime metricset #4887

Merged
merged 3 commits into from Aug 14, 2017

Conversation

Projects
None yet
5 participants
@andrewkroh
Member

andrewkroh commented Aug 11, 2017

This adds a new metricset that reports the system uptime. The metricset
is enabled by default with a period of 15m.

The metricset reports one field system.uptime.duration.ms that is the system's
uptime reported in milliseconds. In Kibana the field is formatted as a duration
and shown in human-readable format (e.g. "8 days").

uptime-kibana

Closes #4848

Add system uptime metricset
This adds a new metricset that reports the system uptime. The metricset
is enabled by default with a period of 15m.

The metricset reports one field `system.uptime.duration.ms` that is the system's
uptime reported in milliseconds. In Kibana the field is formatted as a `duration`
and shown in human-readable format (e.g. "8 days").

Closes #4848
@exekias

LGTM, left a minor comment

- module: system
period: 15m
metricsets: [uptime]

This comment has been minimized.

@exekias

exekias Aug 14, 2017

Member

I'm wondering if this format (instead of a list with -) may confuse some users, as we don't follow the same pattern in the whole file. WDYT?

This comment has been minimized.

@andrewkroh

andrewkroh Aug 14, 2017

Member

I agree. Changed to block style.

@tsg

tsg approved these changes Aug 14, 2017 edited

Nice 👍

@ruflin

ruflin approved these changes Aug 14, 2017

Nice addition about the input_format.

@@ -79,6 +79,11 @@ def field_to_json(fields, desc, path, output,
if "format" in desc:
fieldFormat["id"] = desc["format"]
if "input_format" in desc:

This comment has been minimized.

@ruflin

ruflin Aug 14, 2017

Collaborator

Nice

This comment has been minimized.

@monicasarbu

monicasarbu Aug 14, 2017

Contributor

Great idea!

@@ -83,6 +83,8 @@ https://github.com/elastic/beats/compare/v6.0.0-beta1...master[Check the HEAD di
- Add http server metricset to support push metrics via http. {pull}4770[4770]
- Make config object public for graphite and http server {pull}4820[4820]
- Add system uptime metricset. {issue}[4848[4848]

This comment has been minimized.

@ruflin

ruflin Aug 14, 2017

Collaborator

Empty line above on purpose?

This comment has been minimized.

@andrewkroh

@ruflin ruflin merged commit 43cd1e7 into elastic:master Aug 14, 2017

6 checks passed

CLA Commit author has signed the CLA
Details
beats-ci Build finished.
Details
codecov/patch 66.66% of diff hit (target 62.39%)
Details
codecov/project 62.4% (+0.01%) compared to e8f55ba
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andrewkroh andrewkroh added the v6.1.0 label Aug 15, 2017

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Add system uptime metricset (elastic#4887)
This adds a new metricset that reports the system uptime. The metricset
is enabled by default with a period of 15m.

The metricset reports one field `system.uptime.duration.ms` that is the system's
uptime reported in milliseconds. In Kibana the field is formatted as a `duration`
and shown in human-readable format (e.g. "8 days").

Closes elastic#4848

@andrewkroh andrewkroh deleted the andrewkroh:feature/mb/system-uptime branch Dec 14, 2017

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Add system uptime metricset (elastic#4887)
This adds a new metricset that reports the system uptime. The metricset
is enabled by default with a period of 15m.

The metricset reports one field `system.uptime.duration.ms` that is the system's
uptime reported in milliseconds. In Kibana the field is formatted as a `duration`
and shown in human-readable format (e.g. "8 days").

Closes elastic#4848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment