Remove setup deprecation message #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
libbeat
needs_backport
We decided to keep `-setup` as a shorthand for setup + run
exekias
force-pushed
the
update-deprecate-warnings
branch
from
9f24430
to
2d2b249
Compare
|
Good catch, thanks. |
exekias
added a commit
to exekias/beats
that referenced
this pull request
Aug 16, 2017
We decided to keep `-setup` as a shorthand for setup + run
exekias
added a commit
to exekias/beats
that referenced
this pull request
Aug 16, 2017
* Unmark setup as deprecated We decided to keep `-setup` as a shorthand for setup + run * Update `test output` help message (cherry picked from commit 8bc9c80)
exekias
removed
the
needs_backport
andrewkroh
pushed a commit
that referenced
this pull request
Aug 16, 2017
jarpy
reviewed
Sep 12, 2017
| runCmd.Flags().AddGoFlag(flag.CommandLine.Lookup("version")) | ||
|
|
||
| runCmd.Flags().MarkDeprecated("version", "version flag has been deprectad, use version subcommand") | ||
| runCmd.Flags().MarkDeprecated("configtest", "setup flag has been deprectad, use configtest subcommand") | ||
| runCmd.Flags().MarkDeprecated("configtest", "configtest flag has been deprectad, use test config subcommand") | ||
|
|
There was a problem hiding this comment.
Found a typo here while playing with Docker tests.
"deprectad" is on a couple of different lines.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Unmark setup as deprecated We decided to keep `-setup` as a shorthand for setup + run * Update `test output` help message (cherry picked from commit 3f60cec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to keep
-setupas a shorthand for setup + run