Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip address of containers to event #5379

Merged
merged 1 commit into from Oct 26, 2017

Conversation

@liketic
Copy link
Contributor

commented Oct 12, 2017

Closes #5282

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2017

Can one of the admins verify this patch?

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2017

@liketic Thanks for the contribution. Could you add a CHANGELOG entry?

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2017

jenkins, test it

@ruflin
ruflin approved these changes Oct 12, 2017
Copy link
Collaborator

left a comment

WFG

@liketic liketic force-pushed the liketic:feature/issues/5282 branch from a2a63d9 to cca8942 Oct 12, 2017

@liketic

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2017

@ruflin Thanks for reviewing this one. I rebased it. Thanks.

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2017

jenkins, test it

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2017

@liketic Thanks for the rebase. Tried to do a "Github commit" myself to fix the issue but a rebase is much nicer.

@liketic liketic force-pushed the liketic:feature/issues/5282 branch 2 times, most recently from f0278ac to 4362b01 Oct 13, 2017

@liketic liketic force-pushed the liketic:feature/issues/5282 branch from 4362b01 to ebf27ef Oct 25, 2017

@liketic

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2017

Hi @ruflin Is this mergeable ? 😄

@exekias exekias merged commit 912455a into elastic:master Oct 26, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
CLA Commit author has signed the CLA
Details
codecov/patch 0% of diff hit (within 100% threshold of 58.58%)
Details
codecov/project 58.59% (+<.01%) compared to d1dfc7e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@exekias

This comment has been minimized.

Copy link
Member

commented Oct 26, 2017

Thank you for your contribution @liketic! 🎉

@liketic liketic deleted the liketic:feature/issues/5282 branch Oct 26, 2017

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017
athom added a commit to athom/beats that referenced this pull request Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.