New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log absolute values for gauges internal metrics #5505

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
3 participants
@tsg
Collaborator

tsg commented Nov 2, 2017

We currently don't have a way for the internal Beats metrics to register
themselves as counters or gauges, so the logging code that prints the
values every 30s assumes they are all counters and prints the difference
since the last update.

This issue has became more pressing in 6.0 because we now have several
common gauges. This PR implements a temporary hack that lists these gauges
in logging code. A follow up PR will create a proper solution for the next
release.

Part of #5433.

Log absolute values for gauges internal metrics
We currently don't have a way for the internal Beats metrics to register
themselves as counters or gauges, so the logging code that prints the
values every 30s assumes they are all counters and prints the difference
since the last update.

This issue has became more pressing in 6.0 because we now have several
common gauges. This PR implements a temporary hack that lists these gauges
in logging code. A follow up PR will create a proper solution for the next
release.

Part of #5433.
"beat.memstats.memory_total": true,
"beat.memstats.memory_alloc": true,
"beat.memstats.gc_next": true,
}

This comment has been minimized.

@andrewkroh

andrewkroh Nov 2, 2017

Member

This one presents a problem because the name is not known ahead of time. Perhaps a pattern could be used to handle it or we just ignore it (I doubt anyone will be using this metric before we have a final solution).

@andrewkroh

andrewkroh Nov 2, 2017

Member

This one presents a problem because the name is not known ahead of time. Perhaps a pattern could be used to handle it or we just ignore it (I doubt anyone will be using this metric before we have a final solution).

This comment has been minimized.

@tsg

tsg Nov 3, 2017

Collaborator

Yeah, I saw that one. I'd say we just ignore it in this phase and it can be handled with the real solution.

@tsg

tsg Nov 3, 2017

Collaborator

Yeah, I saw that one. I'd say we just ignore it in this phase and it can be handled with the real solution.

@kvch

kvch approved these changes Nov 3, 2017

@kvch kvch merged commit 6f8d5eb into elastic:6.0 Nov 3, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
CLA Commit author is a member of Elasticsearch
Details
beats-ci Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

tsg added a commit to tsg/beats that referenced this pull request Nov 3, 2017

Log absolute values for gauges internal metrics (elastic#5505)
We currently don't have a way for the internal Beats metrics to register
themselves as counters or gauges, so the logging code that prints the
values every 30s assumes they are all counters and prints the difference
since the last update.

This issue has became more pressing in 6.0 because we now have several
common gauges. This PR implements a temporary hack that lists these gauges
in logging code. A follow up PR will create a proper solution for the next
release.

Part of elastic#5433.

(cherry picked from commit 6f8d5eb)

@tsg tsg removed the needs_backport label Nov 3, 2017

ruflin added a commit that referenced this pull request Nov 7, 2017

Log absolute values for gauges internal metrics (#5505) (#5507)
We currently don't have a way for the internal Beats metrics to register
themselves as counters or gauges, so the logging code that prints the
values every 30s assumes they are all counters and prints the difference
since the last update.

This issue has became more pressing in 6.0 because we now have several
common gauges. This PR implements a temporary hack that lists these gauges
in logging code. A follow up PR will create a proper solution for the next
release.

Part of #5433.

(cherry picked from commit 6f8d5eb)

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Log absolute values for gauges internal metrics (elastic#5505) (elast…
…ic#5507)

We currently don't have a way for the internal Beats metrics to register
themselves as counters or gauges, so the logging code that prints the
values every 30s assumes they are all counters and prints the difference
since the last update.

This issue has became more pressing in 6.0 because we now have several
common gauges. This PR implements a temporary hack that lists these gauges
in logging code. A follow up PR will create a proper solution for the next
release.

Part of elastic#5433.

(cherry picked from commit 6f8d5eb)

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Log absolute values for gauges internal metrics (elastic#5505) (elast…
…ic#5507)

We currently don't have a way for the internal Beats metrics to register
themselves as counters or gauges, so the logging code that prints the
values every 30s assumes they are all counters and prints the difference
since the last update.

This issue has became more pressing in 6.0 because we now have several
common gauges. This PR implements a temporary hack that lists these gauges
in logging code. A follow up PR will create a proper solution for the next
release.

Part of elastic#5433.

(cherry picked from commit 6f8d5eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment