New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test stability #5567

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
4 participants
@ruflin
Collaborator

ruflin commented Nov 13, 2017

Currently CI is constantly failing because of flaky Kafka and sometimes Kibana tests. This skips the Kafka tests for now and increases the timeout for the Kibana tests. This should make our CI builds useful again and not constantly red.

For Kafka a follow up PR is here to remove the test skipping again and make it more stable.

@exekias

LGTM

Improve test stability
Currently CI is constantly failing because of flaky Kafka and sometimes Kibana tests. This skips the Kafka tests for now and increases the timeout for the Kibana tests. Same is done for Dropwizard. The timeout for the locks was increase to see if it helps to make the builds more stable. This should make our CI builds useful again and not constantly red.

For Kafka a follow up PR is here to remove the test skipping again and make it more stable.
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Nov 14, 2017

Collaborator

It seems the failing tests are now temporarily flaky tests :-(

Collaborator

ruflin commented Nov 14, 2017

It seems the failing tests are now temporarily flaky tests :-(

@andrewkroh andrewkroh merged commit 3b171b4 into elastic:master Nov 14, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
beats-ci Build finished.
Details
CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
hound No violations found. Woof!

@ruflin ruflin deleted the ruflin:improve-test-stability branch Nov 14, 2017

@tsg tsg added the needs_backport label Nov 15, 2017

tsg added a commit to tsg/beats that referenced this pull request Nov 15, 2017

Improve test stability (elastic#5567)
Currently CI is constantly failing because of flaky Kafka and sometimes Kibana tests. This skips the Kafka tests for now and increases the timeout for the Kibana tests. Same is done for Dropwizard. The timeout for the locks was increase to see if it helps to make the builds more stable. This should make our CI builds useful again and not constantly red.

For Kafka a follow up PR is here to remove the test skipping again and make it more stable.

(cherry picked from commit 3b171b4)

@tsg tsg removed the needs_backport label Nov 15, 2017

exekias added a commit that referenced this pull request Nov 15, 2017

Improve test stability (#5567) (#5594)
Currently CI is constantly failing because of flaky Kafka and sometimes Kibana tests. This skips the Kafka tests for now and increases the timeout for the Kibana tests. Same is done for Dropwizard. The timeout for the locks was increase to see if it helps to make the builds more stable. This should make our CI builds useful again and not constantly red.

For Kafka a follow up PR is here to remove the test skipping again and make it more stable.

(cherry picked from commit 3b171b4)

ramon-garcia added a commit to ramon-garcia/beats that referenced this pull request Dec 5, 2017

Improve test stability (elastic#5567)
Currently CI is constantly failing because of flaky Kafka and sometimes Kibana tests. This skips the Kafka tests for now and increases the timeout for the Kibana tests. Same is done for Dropwizard. The timeout for the locks was increase to see if it helps to make the builds more stable. This should make our CI builds useful again and not constantly red.

For Kafka a follow up PR is here to remove the test skipping again and make it more stable.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

Improve test stability (elastic#5567)
Currently CI is constantly failing because of flaky Kafka and sometimes Kibana tests. This skips the Kafka tests for now and increases the timeout for the Kibana tests. Same is done for Dropwizard. The timeout for the locks was increase to see if it helps to make the builds more stable. This should make our CI builds useful again and not constantly red.

For Kafka a follow up PR is here to remove the test skipping again and make it more stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment