New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix float32 normalizeValue panic #6129

Merged
merged 3 commits into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@iahmedov
Contributor

iahmedov commented Jan 21, 2018

Closes #6128

@elasticmachine

This comment has been minimized.

elasticmachine commented Jan 21, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ruflin

This comment has been minimized.

Collaborator

ruflin commented Jan 21, 2018

@iahmedov Thanks for the fix. Could you add a CHANGELOG entry?

@urso Could you have a quick look at this?

@ruflin

This comment has been minimized.

Collaborator

ruflin commented Jan 21, 2018

jenkins, test it

@ruflin ruflin added the review label Jan 21, 2018

@ruflin

ruflin approved these changes Jan 21, 2018

jenkins, test it

@urso

This comment has been minimized.

Collaborator

urso commented Jan 22, 2018

Nice. One. As changelogs are consumer by users, not developers let's rephrase the changelog to fix panic when Events containing a float32 value are normalized.

@ruflin

This comment has been minimized.

Collaborator

ruflin commented Jan 22, 2018

jenkins, test it

@urso

urso approved these changes Jan 22, 2018

@ruflin ruflin merged commit c7ac03a into elastic:master Jan 23, 2018

2 of 5 checks passed

beats-ci Build finished.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
CLA Commit author has signed the CLA
Details
hound No violations found. Woof!
@ruflin

This comment has been minimized.

Collaborator

ruflin commented Jan 23, 2018

@iahmedov Thanks a lot for the fix.

athom added a commit to athom/beats that referenced this pull request Jan 25, 2018

@urso urso removed the needs_backport label Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment