New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: support broken status line #6631

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@adriansr
Member

adriansr commented Mar 22, 2018

User reports some HTTP servers may respond with a broken status line that's missing a space between the status code and the optional status phrase. HTTP clients tested already support this behavior. This patch adjusts the http parser so that this deviation from the standard is accepted.

Fixes #6176

http: support broken status line
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes #6176
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Mar 23, 2018

Collaborator

Could you add an entry to the CHANGELOG. Failing tests are not related.

Collaborator

ruflin commented Mar 23, 2018

Could you add an entry to the CHANGELOG. Failing tests are not related.

Updated CHANGELOG for #6631
Added new feature to packetbeat:
- Support broken status line
@adriansr

This comment has been minimized.

Show comment
Hide comment
@adriansr
Member

adriansr commented Mar 23, 2018

@Rufflin done

@ruflin ruflin merged commit d727a45 into elastic:master Mar 26, 2018

2 of 4 checks passed

beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
CLA Commit author is a member of Elasticsearch
Details
hound No violations found. Woof!

adriansr added a commit to adriansr/beats that referenced this pull request Apr 3, 2018

http: support broken status line (elastic#6631)
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176

adriansr added a commit to adriansr/beats that referenced this pull request Apr 3, 2018

http: support broken status line (elastic#6631)
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176

@andrewkroh andrewkroh added the v6.3.0 label Apr 3, 2018

andrewkroh added a commit that referenced this pull request Apr 3, 2018

http: support broken status line (#6631) (#6740)
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes #6176

adriansr added a commit to adriansr/beats that referenced this pull request Apr 5, 2018

http: support broken status line (elastic#6631)
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176

adriansr added a commit to adriansr/beats that referenced this pull request Apr 6, 2018

http: support broken status line (elastic#6631)
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes elastic#6176

andrewkroh added a commit that referenced this pull request Apr 6, 2018

http: support broken status line (#6631)
User reports some HTTP servers may respond with a broken status line that's
missing a space between the status code and the optional status phrase. HTTP
clients tested already support this behavior. This patch adjusts the http
parser so that this deviation from the standard is accepted.

Fixes #6176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment