Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update haproxy.asciidoc #6857

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
6 participants
@OleOle7177
Copy link
Contributor

commented Apr 13, 2018

Fix stats port number

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Apr 13, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jsoriano

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

@OleOle7177 good catch :) Could you please run make update to regenerate documentation and commit the changes?

And you'd also need to sign the CLA.

Thanks!

Update haproxy.asciidoc
Fix stats port number

@OleOle7177 OleOle7177 force-pushed the OleOle7177:patch-2 branch from 9a74c61 to de5eb0b Apr 13, 2018

@OleOle7177

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2018

@jsoriano thanks,
I've signed CLA and ran make update (no changes).

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2018

This PR is against 6.2. Normally we do PR's against master and then backport it from there.

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2018

@OleOle7177 Could you open the same PR against master? It's ok to keep this 6.2 too.

@OleOle7177

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2018

@ruflin Sure, here it is: #6869

@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2018

jenkins, test it

1 similar comment
@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2018

jenkins, test it

@ph

This comment has been minimized.

Copy link
Member

commented Apr 18, 2018

Jenkins test this please

@ruflin ruflin merged commit 91cfc08 into elastic:6.2 Apr 18, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
beats-ci Build started sha1 is merged.
Details
CLA Commit author has signed the CLA
Details
Hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.