Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions at systemd unit file #7873

Merged
merged 1 commit into from Aug 7, 2018
Merged

Conversation

ppanagiotis
Copy link
Contributor

Systemd unit has wrong permissions. So systemd logs:
Configuration file /lib/systemd/system/auditbeat.service is marked executable. Please remove executable permission bits. Proceeding anyway

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@andrewkroh
Copy link
Member

andrewkroh commented Aug 6, 2018

@ppanagiotis Would you mind git apply'ing this patch to the PR. It includes a test case that checks the mode of the unit file for RPMs and .debs. You just download the file to your repo and run git apply systemd_unit_permissions_test.patch.txt. Then commit the file as usual and push. Then we'll have a failing test to go with the fix.

systemd_unit_permissions_test.patch.txt

>> Testing package contents
--- FAIL: TestRPM (0.00s)
    --- FAIL: TestRPM/auditbeat-7.0.0-alpha1-x86_64.rpm_systemd_unit_file_permissions (0.00s)
    	package_test.go:259: file /lib/systemd/system/auditbeat.service has wrong permissions: expected=-rw-r--r-- actual=-rwxr-xr-x
    --- FAIL: TestRPM/auditbeat-oss-7.0.0-alpha1-x86_64.rpm_systemd_unit_file_permissions (0.00s)
    	package_test.go:259: file /lib/systemd/system/auditbeat.service has wrong permissions: expected=-rw-r--r-- actual=-rwxr-xr-x
--- FAIL: TestDeb (0.55s)
    --- FAIL: TestDeb/auditbeat-7.0.0-alpha1-amd64.deb_systemd_unit_file_permissions (0.00s)
    	package_test.go:259: file ./lib/systemd/system/auditbeat.service has wrong permissions: expected=-rw-r--r-- actual=-rwxr-xr-x
    --- FAIL: TestDeb/auditbeat-oss-7.0.0-alpha1-amd64.deb_systemd_unit_file_permissions (0.00s)
    	package_test.go:259: file ./lib/systemd/system/auditbeat.service has wrong permissions: expected=-rw-r--r-- actual=-rwxr-xr-x
FAIL
FAIL	command-line-arguments	1.142

@andrewkroh
Copy link
Member

It looks like this is your first contribution. 👏 As such, can you please sign the Contributor License Agreement?

Systemd unit has wrong permissions. So systemd logs:
`Configuration file /lib/systemd/system/auditbeat.service is marked executable.
 Please remove executable permission bits. Proceeding anyway`
@ppanagiotis
Copy link
Contributor Author

Done.

@andrewkroh andrewkroh merged commit 2b6d468 into elastic:master Aug 7, 2018
@andrewkroh andrewkroh added needs_backport PR is waiting to be backported to other branches. Packaging labels Aug 31, 2018
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request Aug 31, 2018
Systemd unit has wrong permissions. So systemd logs:

`Configuration file /lib/systemd/system/auditbeat.service is marked executable.
 Please remove executable permission bits. Proceeding anyway`

(cherry picked from commit 2b6d468)
@andrewkroh andrewkroh added v6.4.1 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 31, 2018
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request Aug 31, 2018
Systemd unit has wrong permissions. So systemd logs:

`Configuration file /lib/systemd/system/auditbeat.service is marked executable.
 Please remove executable permission bits. Proceeding anyway`

(cherry picked from commit 2b6d468)
andrewkroh added a commit that referenced this pull request Sep 4, 2018
Systemd unit has wrong permissions. So systemd logs:

`Configuration file /lib/systemd/system/auditbeat.service is marked executable.
 Please remove executable permission bits. Proceeding anyway`

(cherry picked from commit 2b6d468)
andrewkroh added a commit that referenced this pull request Sep 4, 2018
Systemd unit has wrong permissions. So systemd logs:

`Configuration file /lib/systemd/system/auditbeat.service is marked executable.
 Please remove executable permission bits. Proceeding anyway`

(cherry picked from commit 2b6d468)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Systemd unit has wrong permissions. So systemd logs:

`Configuration file /lib/systemd/system/auditbeat.service is marked executable.
 Please remove executable permission bits. Proceeding anyway`

(cherry picked from commit 9dba758)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants