New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique event log for Winlogbeat system tests #8006

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@andrewkroh
Member

andrewkroh commented Aug 17, 2018

This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes #7902

Use unique event log for Winlogbeat system tests
This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes #7902

@ruflin ruflin merged commit 4da32c4 into elastic:master Aug 20, 2018

6 checks passed

CLA Commit author has signed the CLA
Details
Hound No violations found. Woof!
beats-ci Build finished.
Details
codecov/patch Coverage not affected when comparing d66cd0d...bbcf994
Details
codecov/project 64.52% (+0.04%) compared to d66cd0d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Aug 20, 2018

Collaborator

Should we backport this to 6.x?

Collaborator

ruflin commented Aug 20, 2018

Should we backport this to 6.x?

@andrewkroh andrewkroh added the v6.5.0 label Aug 21, 2018

andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 21, 2018

Use unique event log for Winlogbeat system tests (elastic#8006)
This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes elastic#7902

(cherry picked from commit 4da32c4)
@andrewkroh

This comment has been minimized.

Show comment
Hide comment
@andrewkroh

andrewkroh Aug 21, 2018

Member

Yes. Backport open in #8038.

Member

andrewkroh commented Aug 21, 2018

Yes. Backport open in #8038.

ruflin added a commit that referenced this pull request Aug 22, 2018

Use unique event log for Winlogbeat system tests (#8006) (#8038)
This changes the Winlogbeat system tests to use a unique event log for each test case.
The event log name and the registered source applications will each be suffixed with
a short hash created from the Windows API name (eventlogging or wineventlog) and the
python test name.

This should help isolate the test cases from one another.

Fixes #7902

(cherry picked from commit 4da32c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment