Join GitHub today
Fix flakey apache module timeout test #8028
This attempts to fix a flakey apache module test by making it less sensitive to timing issues.
Before this patch there was only 50ms for slack for the timeout to happen. My thesis here is that under contention > 50ms of delay was introduced, likely by the Kernel thread scheduler.
By switching to a wait group we have a more deterministic test. Additionally, we now cleanup the server go routine more precisely. It now ends exactly when the test is done, instead of us having it hang around for a fixed interval.