New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metricbeat: Replace ceph image from demo to daemon #8044

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@jsoriano
Member

jsoriano commented Aug 21, 2018

No description provided.

@@ -11,3 +8,8 @@ HEALTHCHECK --interval=1s --retries=300 \
| jq .output.health.health_services[0].mons[0] \
| grep health
EXPOSE 5000
ENV NETWORK_AUTO_DETECT 4

This comment has been minimized.

@jsoriano

jsoriano Aug 22, 2018

Member

I couldn't make it work with static config as we had before, but it seems to work with this.

@jsoriano

jsoriano Aug 22, 2018

Member

I couldn't make it work with static config as we had before, but it seems to work with this.

@@ -11,3 +8,8 @@ HEALTHCHECK --interval=1s --retries=300 \
| jq .output.health.health_services[0].mons[0] \
| grep health
EXPOSE 5000
ENV NETWORK_AUTO_DETECT 4
ENV DEMO_DAEMONS osd,rest_api

This comment has been minimized.

@jsoriano

jsoriano Aug 22, 2018

Member

New image starts a UI in the same port as the rest_api, preventing the rest_api to work, I'm not sure what is the daemon starting the UI, but with this set of daemons the api starts correctly.

@jsoriano

jsoriano Aug 22, 2018

Member

New image starts a UI in the same port as the rest_api, preventing the rest_api to work, I'm not sure what is the daemon starting the UI, but with this set of daemons the api starts correctly.

@exekias

Thank you for taking this one and fix it so quickly!

@exekias

This comment has been minimized.

Show comment
Hide comment
@exekias

exekias Aug 22, 2018

Member

jenkins, retest this please

Member

exekias commented Aug 22, 2018

jenkins, retest this please

@ruflin

ruflin approved these changes Aug 22, 2018

@jsoriano

This comment has been minimized.

Show comment
Hide comment
@jsoriano

jsoriano Aug 22, 2018

Member

Thanks to @andrewvc for starting to investigate the issue!

Member

jsoriano commented Aug 22, 2018

Thanks to @andrewvc for starting to investigate the issue!

@exekias exekias merged commit a2b0f15 into elastic:master Aug 22, 2018

5 of 6 checks passed

beats-ci Build finished.
Details
CLA Commit author has signed the CLA
Details
Hound No violations found. Woof!
codecov/patch Coverage not affected when comparing be71c60...3b6a556
Details
codecov/project 64.48% (+4.09%) compared to be71c60
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@exekias

This comment has been minimized.

Show comment
Hide comment
@exekias

exekias Aug 22, 2018

Member

failing test is unrelated to this change

Member

exekias commented Aug 22, 2018

failing test is unrelated to this change

jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 22, 2018

jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 22, 2018

@jsoriano jsoriano added the v6.4.0 label Aug 22, 2018

jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 22, 2018

ruflin added a commit that referenced this pull request Aug 22, 2018

ruflin added a commit that referenced this pull request Aug 22, 2018

ruflin added a commit that referenced this pull request Aug 22, 2018

@jsoriano jsoriano deleted the jsoriano:ceph-daemon-image branch Sep 5, 2018

jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 5, 2018

@jsoriano jsoriano added the v6.3.3 label Sep 5, 2018

jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 5, 2018

jsoriano added a commit that referenced this pull request Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment