Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make fb BOM test lest flaky through parameterization #8085
The unicode BOM tests in test_harvester.py have been flaky (see #8032). It appears that the tests are potentially publishing the same event twice. The theory behind this patch is that the cause is the test for one BOM reading another BOM's log file.
This PR does two things to fix this:
The second fix really shouldn't do anything due to 1, but it is always better to have more specific and defensive code regardless.
referenced this pull request
Aug 24, 2018
As the python tests are very stateful, we should not do table-driven tests as it has been done before this change.
The tests create a directory with inputs, outputs, configs, logs for debugging and inspection. Does the 'parameterized' decorate affect these directory names? Each test must have it's own unique directory.
@urso yes, each parameterized test uses its own dir. So, as I said, the two changes I made here are a bit belt + suspenders, but I think it's still nice.
Quoted below is the file layout from the BOM tests on this branch.